Skip to content

Support React 19#91

Merged
adcentury merged 1 commit intoadcentury:mainfrom
mksh:react19
Mar 17, 2025
Merged

Support React 19#91
adcentury merged 1 commit intoadcentury:mainfrom
mksh:react19

Conversation

@mksh
Copy link
Contributor

@mksh mksh commented Jan 18, 2025

Currently, package.json of react-mobile-picker only allows using this project in projects based on React versions 16-18.
This PR adds support for React 19 and updates package-lock.json and pnpm-lock.yaml to include React 19 versions using following versions of tools:

➜  react-mobile-picker git:(react19) npm --version
10.9.0
➜  react-mobile-picker git:(react19) pnpm --version
9.13.0

I tested examples, and integrated the code into React 19 project and it all works just fine.

@vercel
Copy link

vercel bot commented Jan 18, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-mobile-picker ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 18, 2025 1:41pm

@mishamaliga mishamaliga mentioned this pull request Feb 4, 2025
Closed
@adcentury adcentury merged commit 7634011 into adcentury:main Mar 17, 2025
2 checks passed
This was referenced Mar 17, 2025
Closed
Closed
@AndreyBottoniLaerdal
Copy link

AndreyBottoniLaerdal commented Mar 21, 2025

Hi @mksh and @adcentury,

I know this PR has already been closed and merged (so sorry to barge in), but I’m curious about something. I’ve been using this library for a year now, currently on version 1.0.1. Today, after making some changes in my project (related to other libraries), I deleted the node_modules folder and ran npm install. When I tried testing my app, clicking on the component that uses this library caused the entire app to crash.

After some troubleshooting, I realized that npm install had pulled in version 1.1 of the library (which I wasn’t aware had been released). Rolling back to 1.0.1 immediately fixed the issue, and my app is now working as expected.

Looking at the merged changes in this PR, I noticed that the package.json update includes React 19 in the peerDependencies, changing the required React and ReactDOM versions from "^18.2.0" to "^19.0.0". My app is currently running React 18.3, so I’m wondering—could this change be the reason my app was crashing?

I’m not very familiar with package.json behavior in this case, but does this update effectively force all users of version 1.1 to upgrade to React 19? I can’t upgrade to React 19 at the moment, so I’ll stick with 1.0.1 for now, but I wanted to clarify how this change impacts existing projects.

Thanks!

adcentury added a commit that referenced this pull request Apr 4, 2025
@adcentury
Revert "Support React 19 (#91)"
74cea10 
This reverts commit 7634011.
@adcentury adcentury mentioned this pull request Apr 4, 2025
Merged
adcentury added a commit that referenced this pull request Apr 4, 2025
@adcentury
Revert "Support React 19 (#91)" (#96)
e5fdf95 
This reverts commit 7634011.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mksh @AndreyBottoniLaerdal @adcentury